Skip to content

Update deploy script for remote dev#61

Merged
MartinBraquet merged 1 commit into
mainfrom
dev
Jul 2, 2026
Merged

Update deploy script for remote dev#61
MartinBraquet merged 1 commit into
mainfrom
dev

Conversation

@MartinBraquet

@MartinBraquet MartinBraquet commented Jul 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved environment validation so deployments only proceed for supported environments.
    • Updated deployment settings to use the correct project and region automatically.
    • Made the API domain adapt to the selected environment instead of always using the production address.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
compass Ignored Ignored Jul 2, 2026 3:19pm
compass-dev Skipped Skipped Jul 2, 2026 3:19pm

@coderabbitai

coderabbitai Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 587a2635-2d45-497c-9bbc-6c40bb4cf2f5

📥 Commits

Reviewing files that changed from the base of the PR and between ec13ea5 and 7869c71.

📒 Files selected for processing (2)
  • backend/api/deploy-api.sh
  • backend/api/main.tf

Walkthrough

Deployment script and Terraform configuration now derive the target GCP project and API domain from an environment parameter (dev or prod) instead of hardcoded production values, with validation added for allowed ENV values.

Changes

Environment-aware deploy config

Layer / File(s) Summary
Deploy script validation and deployment
backend/api/deploy-api.sh		 Validates ENV as dev or prod, selects PROJECT and DOMAIN conditionally, adds --project flag to gcloud deploy, and outputs the computed domain instead of a hardcoded URL.
Terraform environment locals and domain mapping
backend/api/main.tf		 Derives is_prod, project, and api_domain locals from var.env, and updates the Cloud Run domain mapping resource to use local.api_domain.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

Not applicable — the changes are configuration-driven conditional logic without multi-component sequential interactions.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MartinBraquet MartinBraquet merged commit 394470c into main Jul 2, 2026
7 of 8 checks passed
@MartinBraquet MartinBraquet deleted the dev branch July 2, 2026 15:19
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MartinBraquet